Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go to 1.9.2 #2993

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Upgrade Go to 1.9.2 #2993

merged 1 commit into from
Dec 21, 2017

Conversation

bboreham
Copy link
Collaborator

I came up with some benchmarks that say it goes a bit faster, but the timings are highly variable from one minute to the next so without spending an hour trying to tie them down let's just upgrade because Go 1.9 is better than Go 1.8.

Right after a release (1.6.7) is a good time to upgrade.

@rade
Copy link
Member

rade commented Dec 17, 2017

I am seeing a bunch of linker warnings

time env GOGC=off CGO_ENABLED=1  go build -i -ldflags "-extldflags \"-static\" -X main.version=3db91bce -s -w" -tags 'netgo unsafe' -o prog/scope ./prog
# github.com/weaveworks/scope/prog
/tmp/go-link-984278339/000005.o: In function `mygetgrouplist':
/tmp/workdir/go/src/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-984278339/000005.o: In function `mygetgrgid_r':
/tmp/workdir/go/src/os/user/cgo_lookup_unix.go:38: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-984278339/000005.o: In function `mygetgrnam_r':
/tmp/workdir/go/src/os/user/cgo_lookup_unix.go:43: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-984278339/000005.o: In function `mygetpwnam_r':
/tmp/workdir/go/src/os/user/cgo_lookup_unix.go:33: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/tmp/go-link-984278339/000005.o: In function `mygetpwuid_r':
/tmp/workdir/go/src/os/user/cgo_lookup_unix.go:28: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoaddrinfo':
(.text+0x85): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoaddr':
(.text+0x5): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametonetaddr':
(.text+0xb5): warning: Using 'getnetbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoproto':
(.text+0x305): warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
/usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libpcap.a(nametoaddr.o): In function `pcap_nametoport':
(.text+0xfb): warning: Using 'getservbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

@bboreham
Copy link
Collaborator Author

We get very similar messages in the current Cortex build (Go 1.9.1) e.g. https://circleci.com/gh/weaveworks/cortex/1493

@rade
Copy link
Member

rade commented Dec 20, 2017

According to golang/go#21421 this works as designed; the warnings were there in earlier golangs but got suppressed.

@bboreham bboreham merged commit 9c01613 into master Dec 21, 2017
@rade rade deleted the golang-1-9-2 branch December 25, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rade rade rade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @rade